BUG: work around some names not available in 2022.12 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case in point: np.hypot is only available in 2023.12, and has gotten the support for scalars in 2024.12. The test for scalars is skipped for versions older than 2024.12, but the test parametrization is evaluated _before_ the skip. Therefore we cannot just use `xp.hypot` in `@parametrize`.
|
Merging straight away to unblock data-apis/array-api-strict#133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case in point:
xp.hypotis only available in 2023.12, and has gotten the support for scalars in 2024.12.The test for scalars is skipped for versions older than 2024.12, but the test parametrization is evaluated before the skip. Therefore we cannot just use
xp.hypotin@parametrize.