feat: add take_along_axis to specifiation
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
API extension
|
As this PR has been discussed during workgroup meetings and has not received any objections, I'll go ahead and merge. |
|
Thank you! This will be very helpful. |
ev-br
changed the title
take_long_axis to specifiationtake_along_axis to specifiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
take_along_axisto take values along a specified dimension #808 by adding support for selecting elements at one-dimensional indices along a specified axis.axiskwarg keyword-only, which differs from the OP (see RFC: addtake_along_axisto take values along a specified dimension #808). This is for consistency withaxiskwargs elsewhere in the specification. The proposal seemed to follow PyTorch in allowing both positional and kwarg, which could be considered allowed behavior, but positional usage won't be portable.