feat(metrics): add progress metrics via collector #17359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
flaneur2020
force-pushed
the
add-progress-metrics
branch
from
9dba57d to
b0a37b0
Compare
zhang2014
reviewed
Jan 25, 2025
| group_by_spill: ProgressValues, | ||
| window_partition_spill: ProgressValues, | ||
| ) { | ||
| let mut guard = self.inner.lock(); |
There was a problem hiding this comment.
tried to use an AtomicPtr instead but finally returned to the Mutex approach 🥲, the exlusive region is not big imo, it only held the lock when query is finished & metrics is scraped.
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
zhang2014
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
this pr is a rework of #17266
instead of maintain a global metrics, this pr use prometheus's Collector to dump the metrics when /metrics is scraped.
Tests
Type of change
This change is