Skip to content

feat(query): support DATE_TRUNC('WEEK', EXPR)->DATE #17407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Feb 5, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

:) select date_trunc('week', '2025-02-05 00:01:00');

select
date_trunc('week', '2025-02-05 00:01:00')

┌─────────────────────────────────────────┐
│ DATE_TRUNC(WEEK, '2025-02-05 00:01:00') │
│ Date │
├─────────────────────────────────────────┤
│ 2025-02-03 │
└─────────────────────────────────────────┘

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

:) select date_trunc('week', '2025-02-05 00:01:00');

select
  date_trunc('week', '2025-02-05 00:01:00')

┌─────────────────────────────────────────┐
│ DATE_TRUNC(WEEK, '2025-02-05 00:01:00') │
│                   Date                  │
├─────────────────────────────────────────┤
│ 2025-02-03                              │
└─────────────────────────────────────────┘
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 5, 2025
@TCeason
Copy link
Collaborator Author

TCeason commented Feb 5, 2025

cc @soyeric128 doc needed

@TCeason TCeason requested review from b41sh and sundy-li February 5, 2025 03:45
@TCeason TCeason added this pull request to the merge queue Feb 5, 2025
Merged via the queue into databendlabs:main with commit 77a9159 Feb 5, 2025
73 checks passed
@TCeason TCeason deleted the fix_17404 branch February 5, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow date_trunc with WEEK presicion
2 participants