Skip to content

fix(query): if arg is Scalar::null or a null column ignore null will invalid #17423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix(query): if arg is Scalar::null or a null column ignore null will invalid #17423

merged 1 commit into from
Feb 7, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Feb 7, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 7, 2025
@TCeason
Copy link
Collaborator Author

TCeason commented Feb 7, 2025

cc @soyeric128 Doc needed.

@sundy-li sundy-li merged commit 34be4e4 into databendlabs:main Feb 7, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: window function with NULL argument panic
2 participants
@TCeason @sundy-li