Skip to content

fix(query): fix variant get string function auto cast null to SQL NULL #17466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Feb 17, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Variant get string function automatically converts json null to SQL NULL to avoid cast failures caused by null values.
for example:

root@0.0.0.0:48000/default> select cast(parse_json('{"key1":null}')->>'key1' as integer);
┌───────────────────────────────────────────────────────┐
│ CAST(parse_json('{"key1":null}') ->> 'key1' AS Int32) │
│                    Nullable(Int32)                    │
├───────────────────────────────────────────────────────┤
│                                                  NULL │
└───────────────────────────────────────────────────────┘
1 row read in 0.024 sec. Processed 1 row, 1 B (41.67 rows/s, 41 B/s)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li February 17, 2025 02:49
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 17, 2025
@BohuTANG BohuTANG merged commit aef0499 into databendlabs:main Feb 17, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: JSON not evaluating null
3 participants