-
Notifications
You must be signed in to change notification settings - Fork 130
adding ipeds finance data #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @balit-raibot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enrich the dataset by adding detailed financial information from the Integrated Postsecondary Education Data System (IPEDS). It provides a structured approach to importing and representing college and university financial data, including various revenue and expenditure categories, across different institution types and control structures for a multi-year period. This integration will enable deeper analysis and insights into the financial landscape of educational institutions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new data, schema, and configuration files for importing IPEDS finance data. The changes are generally good, but I've identified a few issues in the schema definitions and configuration files. These include an incorrect rangeIncludes for a property, a missing rangeIncludes, a recurring typo, inconsistent capitalization in names, and a minor formatting issue. Addressing these will improve the correctness and maintainability of the new schema.
| Node: dcid:expenditureType | ||
| typeOf: dcs:Property | ||
| name: "expenditureType" | ||
| rangeIncludes: dcid:InvestmentProgramEnum,dcid:ConsumerGoodsCategoryEnum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rangeIncludes for the expenditureType property seems incorrect. It's currently set to dcid:InvestmentProgramEnum,dcid:ConsumerGoodsCategoryEnum. However, the values used in finance_ipeds_pvmap.csv for this property (e.g., TotalExpenses, Instruction) are defined in this file as being of typeOf: dcid:ExpenditureTypeEnum. Please correct the rangeIncludes to dcid:ExpenditureTypeEnum.
rangeIncludes: dcid:ExpenditureTypeEnum
statvar_imports/finance_ipeds/finance_ipeds_output_stat_vars_schema.mcf
Outdated
Show resolved
Hide resolved
| Node: dcid:revenueSource | ||
| typeOf: dcs:Property | ||
| name: "revenueSource" | ||
| domainIncludes: dcid:ExpenditureActivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revenueSource property is missing a rangeIncludes. Based on the values used in finance_ipeds_pvmap.csv (e.g., TotalRevenueInvestmentReturn, TuitionAndFees), which are defined as typeOf: dcid:RevenueSourceEnum, it would be beneficial for schema validation and clarity to add rangeIncludes: dcid:RevenueSourceEnum.
domainIncludes: dcid:ExpenditureActivity
rangeIncludes: dcid:RevenueSourceEnum
|
|
||
| Node: dcid:TuitionAndFees | ||
| typeOf: dcid:RevenueSourceEnum | ||
| name: "Tuition And Fees" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capitalization in the name property seems inconsistent across the file. For example, "Tuition And Fees" and "Grants And Contracts" use a capitalized "And". For better readability and consistency, it's common practice to lowercase conjunctions like "and", "of", etc. in titles. Please consider changing this to "Tuition and Fees". This applies to other similar names in this file.
name: "Tuition and Fees"
No description provided.