This repository was archived by the owner on May 17, 2024. It is now read-only.
update TRIM to LTRIM(RTRIM(...)) for more universal query syntax
#886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL Server versions before 2017 don't support trim, only ltrim and rtrim. this should be universal across databases.
Contributor
|
Hi @MiConnell , I'm sorry for the delay in following up on this. Thank you for taking the time to open this PR! We made a hard decision to sunset the data-diff package and won't provide further development or support. SQL Server 2019+ is now fully supported in Datafold Cloud. As for the earlier SQL Server versions, the lack of UTF8 support makes efficient diffing very hard. -Gleb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL Server versions before 2017 don't support trim, only ltrim and rtrim. this should be universal across databases.
referenced in #885