Skip to content

fix case of f(scalar, array) invocation #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

davidhewitt
Copy link
Collaborator

@davidhewitt davidhewitt commented Jan 9, 2025

Originally reported in https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1736338644684009

This case was completely unhandled, the ColumnarValue::Array argument to the function would be discarded, treating the path entry as null and therefore just returning null overall.

There may yet be another bug lurking in that thread; I'm still investigating.

@davidhewitt davidhewitt force-pushed the dh/scalar-column-invoke branch from 2c52719 to cc34775 Compare January 9, 2025 13:38
@davidhewitt davidhewitt force-pushed the dh/scalar-column-invoke branch from cc34775 to 7fc419a Compare January 9, 2025 13:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 74.79675% with 31 lines in your changes missing coverage. Please review.

Project coverage is 84.22%. Comparing base (4956e2b) to head (25fcffd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/common.rs 75.40% 26 Missing and 4 partials ⚠️
src/rewrite.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   84.17%   84.22%   +0.04%     
==========================================
  Files          15       15              
  Lines         986     1014      +28     
  Branches      986     1014      +28     
==========================================
+ Hits          830      854      +24     
- Misses        109      111       +2     
- Partials       47       49       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhewitt
Copy link
Collaborator Author

davidhewitt commented Jan 9, 2025

nightly bug is an ICE in rust-lang/rust#135235, not an issue for merge

@davidhewitt davidhewitt enabled auto-merge (squash) January 9, 2025 14:39
@davidhewitt davidhewitt disabled auto-merge January 9, 2025 14:39
@davidhewitt davidhewitt force-pushed the dh/scalar-column-invoke branch from 8749206 to 7fc419a Compare January 14, 2025 13:51
@davidhewitt davidhewitt enabled auto-merge (squash) January 14, 2025 14:01
@davidhewitt davidhewitt merged commit 38caf97 into main Jan 14, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/scalar-column-invoke branch January 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants