-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): add user location to user profile page #12016
Merged
jjoyce0510
merged 25 commits into
datahub-project:master
from
samanthafigueredo5:sfiguere_uhg-add-user-location-to-profile
Feb 12, 2025
Merged
feat(UI): add user location to user profile page #12016
jjoyce0510
merged 25 commits into
datahub-project:master
from
samanthafigueredo5:sfiguere_uhg-add-user-location-to-profile
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
reviewed
Dec 9, 2024
jjoyce0510
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some comments. Overall looks promising!
…lement try-catch for countryCode and refine countryCode check
jjoyce0510
reviewed
Jan 17, 2025
@jjoyce0510 My understanding is that, unrelated tests are failing. You said that you are okay to approve and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
needs-review
Label for PRs that need review from a maintainer.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This feature pulls datahub users location country and adds it to their user profile page displayed as such.
This PR involves an additional SGV globe icon and the addition of a new package for converting user country code to country.