Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to show full title in lineage by default #12078

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Blize
Copy link

@Blize Blize commented Dec 10, 2024

Info

In our deployment of datahub, we have a lot of entities with pretty long titles (many including "."). This results in most of our users having to tick the "show full titles" checkbox over and over again.

To ease their work, we propose a config flag to default the titles in the lineage view to their full length, while of course keeping backwards compatibility for users without this need.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 10, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 10, 2024
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...web-react/src/app/lineage/LineageVizInsideZoom.tsx 20.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
...web-react/src/app/lineage/LineageVizInsideZoom.tsx 39.70% <20.00%> (-0.45%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c314707...22819a3. Read the comment docs.

@Blize
Copy link
Author

Blize commented Jan 29, 2025

@hsheth2, @gabe-lyons, @treff7es. Would appreciate a quick review. It's a rather small change, but would still be a nice to have for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant