-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(powerbi): Report to Dashboard lineage #12451
feat(powerbi): Report to Dashboard lineage #12451
Conversation
…ashboardContainsDashboard
…ashboardContainsDashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
Continue to review full report in Codecov by Sentry.
|
…ashboardContainsDashboard
… add missing case for dashboards
…insDashboard' into feature/cus-3571/feat-powerbi-report-to-dashboard-lineage
…ashboardContainsDashboard
…insDashboard' into feature/cus-3571/feat-powerbi-report-to-dashboard-lineage
dataset=None, | ||
**new_dataset_or_report(instance), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for cleaning this up
are there any entries in Constant
that can be removed now?
createdFrom: CreatedFrom | ||
|
||
dataset: Optional["PowerBIDataset"] | ||
report: Optional[Report] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are report_id and report set at the same time? if not, it might be worth putting a comment that says the latter is filled in at a later time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ids are set on a first traversal and objects in a later one
I will add a comment
downstream_dashboards_edges = [] | ||
for d in workspace.dashboards.values(): | ||
if any(t.report_id == report.id for t in d.tiles): | ||
dashboard_urn = builder.make_dashboard_urn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems worrying that these lines weren't covered by the tests? as per the codecov report
also, to make sure I understand - the lineage is tile -> dashboard -> report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems worrying that these lines weren't covered by the tests? as per the codecov report
this may be a sort of false positive, because my update on default_mock_response.json
was specifically tailored to force this code path
also, to make sure I understand - the lineage is tile -> dashboard -> report?
Lineage is represented with a contains relationship. Any PowerBI Dashboard having a PowerBI Tile which references a parent PowerBI Report is modelled as follows:
PowerBI Report (DataHub Dashboard) -- contains --> PowerBI Dashboard (DataHub Dashboard) // this is the new addtion
PowerBI Dashboard (DataHub Dashboard) --contains --> PowerBI Tile (DataHub Chart) // this one was already supported
This was confirmed with users to match their expectations; this is how is modelled in PowerBI Lineage.
merging; CI error is unrelated |
PowerBI Report
objects (mapped as DataHubDashboards
) can containPowerBI Dashboard
objects (also DataHubDashboards
).Important
Depends on PR #12433
Checklist