Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): better experience for analytics charts #12462

Merged

Conversation

kevinkarchacryl
Copy link
Contributor

@kevinkarchacryl kevinkarchacryl commented Jan 24, 2025

Combined with this PR, should fix the analytics charts #12461

Charts for these three currently look like this. They have the full date which isn't necessary.
image
image
image

After these changes, the charts look like this, without the full month/day/year:

image
image
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 24, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../analyticsDashboard/components/TimeSeriesChart.tsx 5.88% 32 Missing ⚠️

❌ Your patch status has failed because the patch coverage (5.88%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
.../analyticsDashboard/components/TimeSeriesChart.tsx 42.92% <5.88%> (-6.78%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb5191...00ca3a7. Read the comment docs.

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 7, 2025
@kevinkarchacryl kevinkarchacryl merged commit 03bce47 into datahub-project:master Feb 7, 2025
184 of 187 checks passed
@kevinkarchacryl kevinkarchacryl deleted the better-ui-chart branch February 7, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants