Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters) Fix autocomplete for platforms and improve advanced search builder #12560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chriscollins3456
Copy link
Collaborator

Our advanced search builder which is used when clicking "+add filter" in the search experience and when building view filters was broken in one way and not optimal in another.

  1. Platforms were not able to be searched for using auto-complete. So platform filters in views were completely broken. I added autocomplete functionality for it on the backend so things are good now.
  2. We didn't do an initial search for dropdowns that should show some initial data, so it required that you type something in the search bar before you see any results. Now i add that initial search to pre-populate data.

screenshots of it working now:
image

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...web-react/src/app/searchV2/filters/value/utils.tsx 4.76% 20 Missing ⚠️
...src/app/searchV2/filters/value/EntityValueMenu.tsx 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (4.16%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...src/app/searchV2/filters/value/EntityValueMenu.tsx 22.35% <0.00%> (ø)
...web-react/src/app/searchV2/filters/value/utils.tsx 31.90% <4.76%> (-3.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66bce0d...a6b7220. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant