-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(graphql): Skip schema fields with empty fieldPaths to prevent the dataset mapper from erroring out #12562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjoyce0510
merged 5 commits into
datahub-project:master
from
jayasimhankv:jk-fix-empty-schema-field
Feb 12, 2025
Merged
fix(graphql): Skip schema fields with empty fieldPaths to prevent the dataset mapper from erroring out #12562
jjoyce0510
merged 5 commits into
datahub-project:master
from
jayasimhankv:jk-fix-empty-schema-field
Feb 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r from erroring out
Codecov ReportAll modified and coverable lines are covered by tests ✅ Continue to review full report in Codecov by Sentry.
|
This PR looks good. Adds checks while retrieving data. |
jjoyce0510
approved these changes
Feb 12, 2025
ttekampe
pushed a commit
to ttekampe/datahub
that referenced
this pull request
Feb 14, 2025
… dataset mapper from erroring out (datahub-project#12562) Co-authored-by: Jay Kadambi <[email protected]>
ksrinath
pushed a commit
to ksrinath/datahub
that referenced
this pull request
Feb 14, 2025
… dataset mapper from erroring out (datahub-project#12562) Co-authored-by: Jay Kadambi <[email protected]>
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 3, 2025
… dataset mapper from erroring out (datahub-project#12562) Co-authored-by: Jay Kadambi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
needs-review
Label for PRs that need review from a maintainer.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
There have been some cases wherein the Schema fieldPath is ingested as an empty string due to which the UI retrieval (or the GQL query) fails in the SchemaMapper. Although the validation on field path has now been introduced with v.0.15 which would prevent schema fields with empty fieldPaths from being ingested, (ref code commit: https://github.com/datahub-project/datahub/blob/master/entity-registry/src/main/java/com/linkedin/metadata/aspect/validation/FieldPathValidator.java#L112), it would be ideal to add a check to eliminate fields with empty fieldPaths before mapping them so such existing datasets could be retrieved. This PR attempts to do so.
Example schema field with empty field path (data ingested pre-v0.15 FieldPathValidator implementation)

Failure retrieving this dataset:

GetDataset call fails:

Mapper error:
java.lang.IllegalArgumentException: Cannot create a Urn from tuple with an empty value
UI works after the fix and eliminates the field with empty fieldPath:

@rtekal - FYI please.
Checklist