Skip to content

feat(quickstart): migrate to compose profile and other improv.#13566

Merged
chakru-r merged 27 commits into
masterfrom
cr-oss-quickstart
Jul 11, 2025
Merged

feat(quickstart): migrate to compose profile and other improv.#13566
chakru-r merged 27 commits into
masterfrom
cr-oss-quickstart

Conversation

@chakru-r
Copy link
Copy Markdown
Collaborator

@chakru-r chakru-r commented May 20, 2025

  • migrate quickstart to use docker-compose profile based files -- that are more frequently used during dev
  • Saves a fully rendered docker-compose file via docker compose config
  • Add disk space checks to pre-flight checks
  • Handle incompatiblities to datahub installed by earlier versions of CLI using the older compose files and provide migration paths
  • CI tests for
    • CLI functional tests and for migration from datahub installed by earlier version of CLI
    • Detect if fully rendered compose file is stale after after build changes that cause changes
    • Run regular tests on previously released versions of datahub and head with latest quickstart CLI to ensure they continue to work (can fail due to external dependency changes)
  • Documentation updates

@github-actions github-actions Bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels May 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 21 lines in your changes missing coverage. Please review.

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.elasticsearch.SearchGraphServiceElasticSearchTest.xml at 681:1058

Caused by:
RuntimeError: Error converting computed name to ValidatedString

Caused by:
    string is too long</code></pre>

For more help, visit our troubleshooting guide.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/cli/docker_cli.py 56.09% 18 Missing ⚠️
metadata-ingestion/src/datahub/cli/docker_check.py 96.15% 2 Missing ⚠️
...ingestion/src/datahub/cli/quickstart_versioning.py 94.73% 1 Missing ⚠️

:loudspeaker: Thoughts on this report? Let us know!

@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 3ff83d8 to 9d05994 Compare May 29, 2025 07:35
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 9d05994 to c904db3 Compare May 29, 2025 08:51
@chakru-r chakru-r changed the title WIP quickstart improvements May 29, 2025
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from c2025d6 to 386eba1 Compare May 29, 2025 10:29
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 386eba1 to 5ad62ff Compare May 29, 2025 10:39
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 5ad62ff to 75686a4 Compare May 29, 2025 10:42
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 75686a4 to 2210b92 Compare May 29, 2025 10:45
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 2210b92 to 3b71132 Compare May 29, 2025 11:24
@chakru-r chakru-r force-pushed the cr-oss-quickstart branch from 3b71132 to 8795527 Compare May 29, 2025 11:51
@chakru-r chakru-r marked this pull request as ready for review June 5, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants