Conversation
Migrate 1,000+ frontend files from legacy color constants (REDESIGN_COLORS, ANTD_GRAY, hardcoded hex values, alchemy colors.X[] palette) to semantic theme tokens (theme.colors.*) from the styled-components ThemeProvider. This builds on the theming infrastructure from PR #14787 and enables light/dark mode support across the entire UI. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
🔴 Meticulous spotted visual differences in 718 of 1321 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 0abee2b. This comment will update as new commits are pushed. |
Remove unused `colors` imports, merge duplicate styled-components imports, fix missing useCallback dependencies, and move styled component out of render body. Co-authored-by: Cursor <cursoragent@cursor.com>
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 70.25kB (0.24%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
- Add global CSS overrides for reactour tooltips (background, text, links) - Replace hardcoded alchemy gray colors in Modal title/subtitle with theme-aware styled components (ModalTitle, ModalSubtitle) - Replace alchemy Heading in WelcomeToDataHubModal with themed SlideTitle/SlideDescription components - Add !important to modal background overrides to beat antd specificity - Fix props shadowing in RecipeBuilder and StructuredPropertyPrompt - Fix useCallback missing dependency in BaseProperty - Extract TriangleButton to fix hooks rules-of-hooks lint error Co-authored-by: Cursor <cursoragent@cursor.com>
…ale imports - Switch dark mode shadows from white-glow rgba to blue-tinted dark rgba matching the palette undertone (Polaris/Atlassian approach) - Fix 23 lint errors: remove unused colors/theme imports, resolve theme variable shadowing in Input/TextArea/NestedOption, fix nested ternary in CustomThemeProvider, merge duplicate styled-components imports - Replace theme.semanticTokens references with proper semantic tokens (buttonFillBrand, borderBrand, textError, textWarning) - Fix SearchBarInput props shadowing bug (nested arrow fn in template) Co-authored-by: Cursor <cursoragent@cursor.com>
… dark mode bg - Tighten shadowXs/shadowSm values for modern Linear/Vercel-style inputs - Fix DocumentTypeProperty overflow:hidden clipping select shadow - Standardize all page containers to use shadowSm consistently - Remove border from HomePageContainer, replace with shadowSm - Remove duplicate shadow from PageWrapper - Add bg background-color to HomePageContainer for dark mode contrast - Update EntityProfile HeaderContent/BodyContent to always use shadowSm - Update StyledSidebar card mode to use shadowSm Co-authored-by: Cursor <cursoragent@cursor.com>
Replace removed HEALTH_INDICATOR_COLOR constant with FAILURE_COLOR_HEX in the twoToneColor prop (Ant Design requires a hex string, not a theme token). This was causing all Cypress tests to crash. Co-authored-by: Cursor <cursoragent@cursor.com>
…om token migration - Fix nested props shadowing in styled-component template literals (PropertyTypeLabel, MarkdownViewer, TermItem x2, SecretField) - Replace bare <label> with <span> in Form.Item label props (ResetCredentials, SignUp) to fix a11y lint errors - Remove unused `shadows` import from Switch/components - Fix Text component types: keep `theme` optional in public API, use internal `ThemedTextProps` for styled-component callbacks - Narrow `Record<string, string>` theme param types to specific property picks for ColorTheme compatibility - Fix `backGround` typo → `background` in GroupMembers (v1 & v2) - Add missing `isExpanded` prop to TableCell styled component type - Cast `color` to `ColorOptions` in Icon.tsx for getColor() compat - Add optional chaining for `useCustomTheme()` in ViewOptionName - Comprehensive semantic token correctness audit across ~130 files - Remove unused constants (LINEAGE_COLORS, sharedV2/colors.ts) - Remove `useTheme() as any` casts, migrate to direct token access - Palette cohesion updates in color.ts for new brand colors Co-authored-by: Cursor <cursoragent@cursor.com>
…e pill contrast
- Add `danger` prop to all destructive menu actions (delete/remove) across
V1 and V2 components so they use themed error styling via Ant Design
- Fix close/dismiss Icon components using `color="icon"` instead of
inheriting unintended link colors from parent elements
- Fix dark mode dropdown submenu styling (background, shadow, text color)
by increasing CSS specificity in GlobalThemeStyles and removing hardcoded
white background in reset-dropdown-menu-styles.less
- Update dark mode hyperlinks to brand violet instead of cyan-blue
- Add `textOnSurface{Error,Information,Success,Warning}` semantic tokens
for high-contrast text on colored pill backgrounds without affecting
standalone status text/icon readability
- Tune dark mode status pill surface colors to darker, more muted values
for better contrast with their text
Co-authored-by: Cursor <cursoragent@cursor.com>
No description provided.