Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
✅ Meticulous spotted 0 visual differences across 1008 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 39fcac7. This comment will update as new commits are pushed. |
Bundle ReportBundle size has no change ✅ |
1 similar comment
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WAR extraction to tmpfs (RAM disk) for 15-30% faster startup. Bypasses OverlayFS overhead by extracting to RAM before class loading. Uses Spring Boot's
classpath.idxfor deterministic,ordered class loading across boots.
Changes
Docker (
docker/datahub-gms/start.sh)/tmp/gms/extactionwhenEXTRACT_JAR_ENABLED=trueclasspath.idxto build deterministic, ordered classpathKubernetes Helm Chart
extractJarEnabled: falseflag tovalues.yaml(disabled by default)deployment.yamlEXTRACT_JAR_ENABLEDenvironment variable to container spec/tmp/gms/extactionWhy This Matters
OverlayFS (Docker/K8s default) adds copy-on-write overhead to every JAR class load. Extracting to tmpfs bypasses this layer traversal entirely:
Performance
Requirements
Startup Output
[STARTUP] JAR extraction enabled. WAR size: 561MB, Available RAM: 3578MB
[STARTUP] Extracting WAR to tmpfs: /tmp/gms/extraction
[STARTUP] WAR extracted in 768ms
[STARTUP] Generating deterministic classpath from BOOT-INF/classpath.idx
[STARTUP] Deterministic classpath: 660 entries (from classpath.idx)
See
docs/jar-extraction-tmpfs-optimization.mdfor detailed documentation.