fix(redshift): use boundary-aware segment stitching for query reconstruction#16253
Draft
kyungsoo-datahub wants to merge 3 commits intomasterfrom
Draft
fix(redshift): use boundary-aware segment stitching for query reconstruction#16253kyungsoo-datahub wants to merge 3 commits intomasterfrom
kyungsoo-datahub wants to merge 3 commits intomasterfrom
Conversation
…ruction Redshift stores queries in fixed-width character(200) or character(4000) segments. RTRIM per-segment and RTRIM(LISTAGG(text)) both fail because character(n) padding is stripped before LISTAGG receives values, merging keywords at boundaries (e.g. GROUP BY -> GROUPBY). Fix: add a space back when trimmed segment length < segment size. Applied to all 5 LISTAGG locations. Also replaced stl_query.querytxt (truncated to 4000 chars) with a CTE from STL_QUERYTEXT in provisioned scan lineage.
github-actions
bot
added
the
ingestion
Contributor
|
Linear: ING-1654 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
- Add relevant_queries CTE to scope STL_QUERYTEXT scan to time-filtered query IDs from stl_insert (fixes unbounded full-table scan) - Extract segment size constants (_PROVISIONED_SEGMENT_SIZE=200, _SERVERLESS_SEGMENT_SIZE=4000) instead of inline magic numbers - Add TODO for pre-existing unscoped CTE in list_insert_create_queries_sql - Add crossed-wire tests (provisioned doesn't use 4000, serverless doesn't use 200)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redshift stores queries in fixed-width character(200) or character(4000) segments. RTRIM per-segment and RTRIM(LISTAGG(text)) both fail because character(n) padding is stripped before LISTAGG receives values, merging keywords at boundaries (e.g. GROUP BY -> GROUPBY).
Fix: add a space back when trimmed segment length < segment size. Applied to all 5 LISTAGG locations. Also replaced stl_query.querytxt (truncated to 4000 chars) with a CTE from STL_QUERYTEXT in provisioned scan lineage.