Skip to content

fix(cypress): v2_glossaryTerm fix filtering by tag (oss)#16273

Open
v-tarasevich-blitz-brain wants to merge 2 commits intomasterfrom
vt--prd-2354-fix-v2-glossary-term-test-oss
Open

fix(cypress): v2_glossaryTerm fix filtering by tag (oss)#16273
v-tarasevich-blitz-brain wants to merge 2 commits intomasterfrom
vt--prd-2354-fix-v2-glossary-term-test-oss

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

Linear: https://linear.app/acryl-data/issue/PRD-2354/fix-v2-glossaryterm

This PR fixes failures of v2_glossaryTerm cypress test

fixed:

Ported from https://github.com/acryldata/datahub-fork/pull/8293

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
101 1 100 0
View the top 2 failed test(s) by shortest run time
siblings cypress/e2e/siblings/siblings.js::cypress/e2e/siblings/siblings.js
Stack Traces | 22.5s run time
2026-02-19T13:38:15.444Z
Timed out retrying after 10000ms: Expected not to find content: 'This is a unique identifier for a customer' but continuously found it.
tests.cypress.integration_test::test_run_cypress
Stack Traces | 714s run time
auth_session = <tests.utils.TestSessionWrapper object at 0x7f401fc9ded0>

    def test_run_cypress(auth_session):
        # Run with --record option only if CYPRESS_RECORD_KEY is non-empty
        record_key = env_vars.get_cypress_record_key()
        tag_arg = ""
        test_strategy = env_vars.get_test_strategy()
        if record_key:
            record_arg = " --record "
            batch_number = os.getenv("BATCH_NUMBER")
            batch_count = os.getenv("BATCH_COUNT")
            if batch_number and batch_count:
                batch_suffix = f"-{batch_number}{batch_count}"
            else:
                batch_suffix = ""
            tag_arg = f" --tag {test_strategy}{batch_suffix}"
        else:
            record_arg = " "
    
        logger.info(f"test strategy is {test_strategy}")
        test_spec_arg = ""
        specs_str = ",".join([f"**/{f}" for f in _get_filtered_or_batched_tests()])
        test_spec_arg = f" --spec '{specs_str}' "
    
        logger.info("Running Cypress tests with command")
        node_options = "--max-old-space-size=500"
        electron_args = 'ELECTRON_EXTRA_LAUNCH_ARGS="--js-flags=\'--max-old-space-size=4096 --disable-dev-shm-usage --disable-gpu --no-sandbox"'
        command = f'{electron_args} NO_COLOR=1 NODE_OPTIONS="{node_options}" npx cypress run {record_arg} {test_spec_arg} {tag_arg}'
        logger.info(command)
        # Add --headed --spec '**/mutations/mutations.js' (change spec name)
        # in case you want to see the browser for debugging
        print_now()
        proc = subprocess.Popen(
            command,
            shell=True,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            cwd=f"{CYPRESS_TEST_DATA_DIR}",
            text=True,  # Use text mode for string output
            bufsize=1,  # Line buffered
        )
        assert proc.stdout is not None
        assert proc.stderr is not None
    
        # Function to read and print output from a pipe
        def read_and_print(pipe, prefix=""):
            for line in pipe:
                logger.info(f"{prefix}{line.rstrip()}")
    
        # Read and print output in real-time
    
        stdout_thread = threading.Thread(target=read_and_print, args=(proc.stdout,))
        stderr_thread = threading.Thread(
            target=read_and_print, args=(proc.stderr, "stderr: ")
        )
    
        # Set threads as daemon so they exit when the main thread exits
        stdout_thread.daemon = True
        stderr_thread.daemon = True
    
        # Start the threads
        stdout_thread.start()
        stderr_thread.start()
    
        # Wait for the process to complete
        return_code = proc.wait()
    
        # Wait for the threads to finish
        stdout_thread.join()
        stderr_thread.join()
    
        logger.info(f"return code: {return_code}")
        print_now()
>       assert return_code == 0
E       assert 1 == 0

tests/cypress/integration_test.py:343: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review February 19, 2026 16:22
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. smoke_test Contains changes related to smoke tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments