feat(docker): replace head tag with quickstart and sha-* tags#17505
Merged
Conversation
Contributor
|
Linear: PFP-3946 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
3720885 to
b95ffae
Compare
devashish2203
approved these changes
May 19, 2026
Contributor
|
Your PR has been assigned to @david-leifker (david.leifker) for review (PFP-3946). |
bd8e1e7 to
496e6d5
Compare
Remove the per-image :head floating tag that could mix commits across services. Master builds publish immutable sha-<short_sha> tags in one coordinated depot bake push; :quickstart is applied only after the full matrix passes smoke tests. Update compose defaults, quickstart manifest/ CLI (--version head maps to quickstart), CI workflows, and document the breaking change. Co-authored-by: Cursor <cursoragent@cursor.com>
Add y/n confirmation when an explicit --version is unrecognized or maps to a deprecated head tag, while keeping semver and sha-* passthrough silent. Omitting --version still uses default without prompting. Add --accept-version-default for non-interactive scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
496e6d5 to
3f175d1
Compare
The :quickstart tag is only published after a green master smoke run, so PR quickstart-test cannot pull acryldata/*:quickstart yet. Use --version default (pinned release) for PR smoke tests; head→quickstart mapping stays in unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Connector Tests ResultsConnector tests failed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
|
🔴 Meticulous spotted visual differences in 5 of 1327 screens tested: view and approve differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataHub master builds used to publish a floating
:headtag on every image. Each service was tagged as its own build finished, so adocker compose pullat any moment could pull a mixed set of commits across GMS, frontend, upgrade, and so on. That is awkward for local quickstart and unsafe for production-style deployments (Kubernetes, Helm), where every pod in a rollout should share one known build.This PR replaces that model with two explicit tag types:
sha-<short_sha>— immutable, per-commit tags published during the build (for pinning in K8s/Helm and production).quickstart— a coordinated floating tag applied only after the full image matrix passes smoke tests onmaster, so all services move together for Compose anddatahub docker quickstart.The legacy
:headregistry tag is removed. Bare short SHA tags (:abc1234) become:sha-abc1234for clarity.The CLI also gains confirmation before silent version fallbacks, so typos and stale cached manifests are less likely to pull the wrong images without the user noticing.
Why
:headquickstartretagged once per green master build (post-smoke)sha-*or releasev*in clustersabc1234vs other identifiers)sha-abc1234--versionor deprecatedheadmapping applied silentlyUser-facing changes
Docker Compose / local quickstart
DATAHUB_VERSION=quickstart(washead).datahub docker quickstart --version headstill works: the quickstart version manifest mapshead→docker_tag: quickstart+composefile_git_ref: master, so older CLIs pick this up from GitHub without a new pip release (cached local manifest may still sayheaduntil refetched).--version quickstartis supported via the manifest.DATAHUB_VERSION=sha-<7-char>(registry-only; not a git tag).--versionstill uses the manifestdefaultentry with no prompt.--versionvalues (e.g. typos likehed) prompt before falling back to the suggested configuration (pinneddefaultfrom the manifest, ormaster+quickstartfor missing magic aliases likehead).v1.2.0) andsha-*continue to pass through as git ref + docker tag without prompting.--accept-version-defaultskips the prompt for scripts/CI (non-interactive runs without this flag abort with a clear error when confirmation would be required).Kubernetes / Helm / production
v*) or immutablesha-*tags.quickstartin cluster manifests; it changes on the next greenmasterbuild.Breaking change
Documented in
docs/how/updating-datahub.md::headis no longer published.:abc1234→:sha-abc1234.:quickstartadded for coordinated local/Compose use only.