Skip to content

refactor(upgrade): move restore-indices boot steps to system-update job#17691

Open
Dutt23 wants to merge 19 commits into
masterfrom
sd/restore-indices-steps
Open

refactor(upgrade): move restore-indices boot steps to system-update job#17691
Dutt23 wants to merge 19 commits into
masterfrom
sd/restore-indices-steps

Conversation

@Dutt23
Copy link
Copy Markdown
Contributor

@Dutt23 Dutt23 commented Jun 2, 2026

## Why

Three index-restore steps (`RestoreColumnLineageIndices`, `RestoreFormInfoIndicesStep`, `RestoreGlossaryIndices`) were running inside GMS bootstrap — blocking startup and running sequentially before GMS could serve traffic. These steps are non-critical to request serving and shouldn't hold up the main startup path.

## What

Moves all three restore-indices steps from `BootstrapManagerFactory` (blocking, sequential) to the `datahub-upgrade` system-update job (non-blocking, out-of-band).

### Changes

- Added wrapper + step classes under `system/restoreindices/{columnlineage,forminfo,glossary}`, preserving all original migration logic
- Wired 3 new beans in `NonBlockingConfigs` with enabled flags
- Added config properties (all default `true`):
  systemUpdate.restoreColumnLineageIndices.enabled
  systemUpdate.restoreFormInfoIndices.enabled
  systemUpdate.restoreGlossaryIndices.enabled
- Removed steps from `BootstrapManagerFactory`; dropped now-unused `_entityRegistry` field and `EntityRegistryFactory` import
- Deleted original boot step source files and their tests
- Added functional tests covering empty-data, MCL-emission, and failure paths

## Impact

GMS startup no longer does work on index restoration. Reduces startup time and eliminates a potential source of slow/failed deployments when index data is large.

> **Note:** To disable any step individually, set the corresponding `systemUpdate.restore*.enabled` flag to `false` in your config.

@github-actions github-actions Bot added the devops PR or Issue related to DataHub backend & deployment label Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

@Dutt23 Dutt23 marked this pull request as ready for review June 3, 2026 07:05
@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 3, 2026
@maggiehays maggiehays added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jun 4, 2026
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 5, 2026

🔴 Meticulous spotted visual differences in 2 of 1427 screens tested: view and approve differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit 9a373ff merge. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Bundle Report

Changes will increase total bundle size by 191 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.54MB 191 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 79 bytes 8.86MB 0.0%
assets/en-*.js 72 bytes 225.17kB 0.03%
assets/de-*.js 40 bytes 47.72kB 0.08%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants