Skip to content

feat(model): add unified system entity data access control#17723

Open
david-leifker wants to merge 1 commit into
masterfrom
system-data-support
Open

feat(model): add unified system entity data access control#17723
david-leifker wants to merge 1 commit into
masterfrom
system-data-support

Conversation

@david-leifker
Copy link
Copy Markdown
Collaborator

Summary

  • Add @SystemEntity / @System PDL annotations and the dataHubSystemState production entity for GMS-internal operational state
  • Enforce system data access at three layers: AuthUtil API gate (403), DAO read filter (SystemDataReadFilter + AspectReadGuard), and write validator (SystemDataWriteValidator / SYSTEM_ACTOR only)
  • Centralize enable/disable via authorization.systemDataAccessControl.enabled (SystemDataAccessControlConfiguration) wired into AuthUtil and plugin registration

Test plan

  • :entity-registry:test — policy, read filter, write validator, annotation parsing
  • :metadata-auth:auth-api:test — AuthUtil system-data gate
  • :metadata-io:test — AspectReadGuard, DAO batchGet/getLatestAspects, Cassandra + Ebean paths
  • :metadata-service:factories:test — Spring plugin wiring
  • smoke-test/tests/system_data/test_system_data_access.py — live GMS against dataHubSystemState

Made with Cursor

@github-actions github-actions Bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Jun 3, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants