Skip to content

feat(ingest): improve sync schedule UX with toggle, info tooltip, and conditional fields#17724

Open
rajatoss wants to merge 4 commits into
masterfrom
feat/ingestion-schedule-toggle-ui
Open

feat(ingest): improve sync schedule UX with toggle, info tooltip, and conditional fields#17724
rajatoss wants to merge 4 commits into
masterfrom
feat/ingestion-schedule-toggle-ui

Conversation

@rajatoss
Copy link
Copy Markdown
Member

@rajatoss rajatoss commented Jun 4, 2026

Summary

Improves the ingestion Sync Schedule UX so a disabled schedule no longer shows confusing time controls, and the "Run on a schedule" affordance reads more clearly.

Applies to both schedule builders:

  • ScheduleSection.tsx — the new multi-step builder (shown when the ingestionOnboardingRedesignV1 flag is on)
  • CreateScheduleStep.tsx — the legacy modal builder (shown when the flag is off)

Changes

  • Inline toggle — the enable/disable switch now sits directly next to the "Run on a schedule (recommended)" heading instead of below it.
  • Info tooltip — the copy "Keep metadata current by automatically syncing on a regular interval" moved out of the toggle label into a hover tooltip on an icon, decluttering the row.
  • Conditional fields — the cron schedule (Every / at / time / View Advanced Settings) and the timezone selector now render only when the toggle is enabled. When disabled, the user just sees the toggle plus the existing out-of-date warning.

Checklist

  • PR conforms to the Contributing Guideline (PR Title Format)
  • Tests added/updated (if applicable) — N/A, presentational change
  • Docs added/updated (if applicable) — N/A
  • No breaking changes
Screenshot 2026-06-03 at 8 50 53 PM Screenshot 2026-06-03 at 8 51 27 PM

… conditional fields

Refine the ingestion "Run on a schedule" UI in both the new multi-step
builder (flag on) and the legacy modal builder (flag off):

- Place the enable/disable toggle inline next to the
  "Run on a schedule (recommended)" heading
- Move the "Keep metadata current by automatically syncing on a regular
  interval" copy into an info (i) icon tooltip on hover
- Only render the schedule (cron) and timezone fields when the toggle is
  enabled, so a disabled schedule no longer shows confusing time controls

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Jun 4, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 160 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.41MB 160 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 160 bytes 8.83MB 0.0%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/builder/CreateScheduleStep.tsx → Total Size: 7.09kB

  • ./src/app/ingestV2/source/multiStepBuilder/steps/step2ConnectionDetails/sections/recipeSection/sections/syncScheduleSection/ScheduleSection.tsx → Total Size: 4.44kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@rajatoss rajatoss self-assigned this Jun 4, 2026
@rajatoss rajatoss requested a review from purnimagarg1 June 4, 2026 06:01
rajatoss added 2 commits June 4, 2026 11:32
Updated tooltip text for the schedule sync option to provide clearer guidance.
@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants