Skip to content

feat(i18n): extract keys from entityv2 shared components#17731

Open
v-tarasevich-blitz-brain wants to merge 4 commits into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities
Open

feat(i18n): extract keys from entityv2 shared components#17731
v-tarasevich-blitz-brain wants to merge 4 commits into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR extracts the i18n keys from

  • entityV2/shared/components
  • entityV2/shared/EntityDropdown

@github-actions github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Jun 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 15.86kB (0.07%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.53MB 15.86kB (0.07%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 4.93kB 8.86MB 0.06%
assets/en-*.js 10.92kB 219.71kB 5.23% ⚠️

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/EntityDropdown/MoveEntityMenuAction.tsx → Total Size: 1.59kB

  • ./src/app/entityV2/shared/EntityDropdown/MoveGlossaryEntityModal.tsx → Total Size: 3.58kB

  • ./src/app/entityV2/shared/EntityDropdown/AnnounceMenuAction.tsx → Total Size: 962 bytes

  • ./src/app/entityV2/shared/EntityDropdown/useDeleteEntity.tsx → Total Size: 3.4kB

  • ./src/app/entityV2/shared/EntityDropdown/UpdateDeprecationModal.tsx → Total Size: 5.97kB

  • ./src/app/entityV2/shared/components/search/InlineListSearch.tsx → Total Size: 1.06kB

  • ./src/app/entityV2/shared/components/styled/ExpandedActorGroup.tsx → Total Size: 1.36kB

  • ./src/app/entityV2/shared/EntityDropdown/CreateGlossaryEntityModal.tsx → Total Size: 8.59kB

  • ./src/app/entityV2/shared/EntityDropdown/versioning/UnlinkAssetVersionModal.tsx → Total Size: 1.59kB

  • ./src/app/entityV2/shared/components/legacy/DescriptionModal.tsx → Total Size: 2.32kB

  • ./src/app/entityV2/shared/components/links/AddEditLinkModal.tsx → Total Size: 2.09kB

  • ./src/app/entityV2/shared/components/styled/AddLinkModal.tsx → Total Size: 1.48kB

  • ./src/app/entityV2/shared/components/links/UploadFileForm.tsx → Total Size: 2.59kB

  • ./src/app/entityV2/shared/components/links/LinkFormWrapper.tsx → Total Size: 2.63kB

  • ./src/app/entityV2/shared/EntityDropdown/DeleteEntityMenuAction.tsx → Total Size: 1.59kB

  • ./src/app/entityV2/shared/EntityDropdown/versioning/LinkAssetVersionModal.tsx → Total Size: 4.24kB

  • ./src/app/entityV2/shared/components/links/UrlLinkForm.tsx → Total Size: 714 bytes

  • ./src/app/entityV2/shared/components/styled/search/DownloadAsCsvModal.tsx → Total Size: 6.57kB

  • ./src/app/entityV2/shared/components/styled/ExpandedOwner/ExpandedOwner.tsx → Total Size: 3.0kB

  • ./src/app/entityV2/shared/components/styled/MarkAsDeprecatedButton.tsx → Total Size: 989 bytes

  • ./src/app/entityV2/shared/EntityDropdown/DomainParentSelect.tsx → Total Size: 2.69kB

  • ./src/app/entityV2/shared/components/styled/DeprecationIcon.tsx → Total Size: 6.35kB

  • ./src/app/entityV2/shared/EntityDropdown/RaiseIncidentMenuAction.tsx → Total Size: 1.27kB

  • ./src/app/entityV2/shared/EntityDropdown/EntityDropdown.tsx → Total Size: 15.35kB

  • ./src/app/entityV2/shared/components/styled/search/EmbeddedListSearch.tsx → Total Size: 9.87kB

  • ./src/app/entityV2/shared/components/links/useLinkUtils.ts → Total Size: 3.96kB

  • ./src/app/entityV2/shared/EntityDropdown/MoveDomainModal.tsx → Total Size: 3.08kB

  • ./src/app/entityV2/shared/EntityDropdown/ChangeHistoryMenuAction.tsx → Total Size: 844 bytes

  • ./src/app/entityV2/shared/EntityDropdown/UpdateDeprecationMenuAction.tsx → Total Size: 2.29kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
datahub-web-react/src/i18n/i18n.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

✅ Meticulous spotted visual differences in 4 of 1429 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit b1e3ed0 Merge branch 'master' into vt--cat-2222--translate-entity-shared-compone.... This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants