Skip to content

feat(i18n): extract keys from entityv2 shared components (second part)#17737

Open
v-tarasevich-blitz-brain wants to merge 1 commit into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-second-part
Open

feat(i18n): extract keys from entityv2 shared components (second part)#17737
v-tarasevich-blitz-brain wants to merge 1 commit into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-second-part

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR extracts i18n keys from these folders (relative to entityV2/shared/):

  • . (root — constants.ts, utils.ts, FilterSelect.tsx, GroupBySelect.tsx)
  • announce
  • DomainSelector
  • embed/UpstreamHealth
  • entity
  • EntitySearchInput
  • EntitySearchSelect
  • externalUrl
  • externalUrl/components/VeiwMoreDropdown
  • graphs
  • notes
  • sidebarSection
  • stats
  • summary
  • versioning

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

✅ Meticulous spotted 0 visual differences across 1302 screens tested: view results.

Meticulous evaluated ~10 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit e18c6fa feat(i18n): extract keys from entityv2 shared components (second part). This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 10.56kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.51MB 10.56kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 3.18kB 8.85MB 0.04%
assets/en-*.js 7.38kB 208.99kB 3.66%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/embed/UpstreamHealth/UpstreamEntitiesList.tsx → Total Size: 2.38kB

  • ./src/app/entityV2/shared/notes/NotesSection.tsx → Total Size: 5.61kB

  • ./src/app/entityV2/shared/constants.ts → Total Size: 4.62kB

  • ./src/app/entityV2/shared/embed/UpstreamHealth/UpstreamHealth.tsx → Total Size: 7.54kB

  • ./src/app/entityV2/shared/EntitySearchInput/EntitySearchInputV2.tsx → Total Size: 1.72kB

  • ./src/app/entityV2/shared/FilterSelect.tsx → Total Size: 1.61kB

  • ./src/app/entityV2/shared/EntitySearchSelect/EntitySearchDropdown.tsx → Total Size: 5.33kB

  • ./src/app/entityV2/shared/summary/SummaryCreatedBySection.tsx → Total Size: 1.57kB

  • ./src/app/entityV2/shared/EntitySearchSelect/ActorsSearchSelect.tsx → Total Size: 5.72kB

  • ./src/app/entityV2/shared/GroupBySelect.tsx → Total Size: 855 bytes

  • ./src/app/entityV2/shared/sidebarSection/UserGroupSidebarSection.tsx → Total Size: 1.38kB

  • ./src/app/entityV2/shared/graphs/RowCountGraph.tsx → Total Size: 1.71kB

  • ./src/app/entityV2/shared/versioning/VersionsPreview.tsx → Total Size: 4.02kB

  • ./src/app/entityV2/shared/externalUrl/components/VeiwMoreDropdown/ViewMoreDropdown.tsx → Total Size: 1.18kB

  • ./src/app/entityV2/shared/utils.ts → Total Size: 8.85kB

  • ./src/app/entityV2/shared/sidebarSection/UserOwnershipSideBarSection.tsx → Total Size: 1.82kB

  • ./src/app/entityV2/shared/DomainSelector/DomainSelector.tsx → Total Size: 6.26kB

  • ./src/app/entityV2/shared/announce/CreateEntityAnnouncementModal.tsx → Total Size: 5.55kB

  • ./src/app/entityV2/shared/sidebarSection/ShowMoreSection.tsx → Total Size: 503 bytes

  • ./src/app/entityV2/shared/versioning/VersionsDrawer.tsx → Total Size: 5.62kB

  • ./src/app/entityV2/shared/summary/SummaryAboutSection.tsx → Total Size: 3.31kB

  • ./src/i18n/i18n.ts → Total Size: 10.79kB

  • ./src/app/entityV2/shared/entity/EntityActions.tsx → Total Size: 12.18kB

  • ./src/app/entityV2/shared/sidebarSection/AboutSidebarSection.tsx → Total Size: 2.72kB

  • ./src/app/entityV2/shared/externalUrl/usePlatformLinks.tsx → Total Size: 2.02kB

  • ./src/app/entityV2/shared/stats/statsUtils.ts → Total Size: 512 bytes

  • ./src/app/entityV2/shared/entity/NonExistentEntityPage.tsx → Total Size: 244 bytes

Files in assets/en-*.js:

  • ./src/i18n/locales/en/entity.shared.emptyStates.json → Total Size: 2.43kB

  • ./src/i18n/locales/en/common.actions.json → Total Size: 2.92kB

  • ./src/i18n/locales/en/entity.shared.actions.json → Total Size: 1.95kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 49.45055% with 46 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...hub-web-react/src/app/entityV2/shared/constants.ts 49.36% 40 Missing ⚠️
datahub-web-react/src/i18n/i18n.ts 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (49.45%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants