Skip to content

feat(i18n): extract keys from queries tab (oss additions)#17738

Open
v-tarasevich-blitz-brain wants to merge 2 commits into
masterfrom
vt--cat-2244--extract-dataset-queries-tab-oss-additions
Open

feat(i18n): extract keys from queries tab (oss additions)#17738
v-tarasevich-blitz-brain wants to merge 2 commits into
masterfrom
vt--cat-2244--extract-dataset-queries-tab-oss-additions

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR contains additions to queries tab extraction

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

✅ Meticulous spotted 0 visual differences across 1387 screens tested: view results.

Meticulous evaluated ~10 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 6ceeb1a resolve comments. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 753 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.56MB 753 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 456 bytes 8.87MB 0.01%
assets/en-*.js 297 bytes 239.28kB 0.12%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Dataset/Timeline/SchemaTimelineSection.tsx → Total Size: 3.24kB

  • ./src/i18n/i18n.ts → Total Size: 12.78kB

  • ./src/app/entityV2/shared/tabs/Dataset/View/ViewDefinitionTab.tsx → Total Size: 3.8kB

Files in assets/en-*.js:

  • ./src/i18n/locales/en/entity.profile.timeline.json → Total Size: 226 bytes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
datahub-web-react/src/i18n/i18n.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 4, 2026
Copy link
Copy Markdown
Contributor

@benjiaming benjiaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes before merge or in follow-up.

Comment thread datahub-web-react/src/i18n/locales/en/entity.profile.timeline.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants