Skip to content

feat(i18n): extract keys from entity v1 shared components#17739

Open
v-tarasevich-blitz-brain wants to merge 3 commits into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-entityV1-components
Open

feat(i18n): extract keys from entity v1 shared components#17739
v-tarasevich-blitz-brain wants to merge 3 commits into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-entityV1-components

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR extracts i18n keys from entity/shared/components

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

🔴 Meticulous spotted visual differences in 2 of 1387 screens tested: view and approve differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit e71208a fix lint errors. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 6.43kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.57MB 6.43kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 2.05kB 8.87MB 0.02%
assets/en-*.js 4.38kB 243.37kB 1.83%

Files in assets/index-*.js:

  • ./src/app/entity/shared/components/styled/search/action/DataProductsDropdown.tsx → Total Size: 2.13kB

  • ./src/app/entity/shared/components/styled/search/DownloadAsCsvButton.tsx → Total Size: 724 bytes

  • ./src/app/entity/shared/components/styled/search/action/DeleteDropdown.tsx → Total Size: 1.45kB

  • ./src/app/entity/shared/components/styled/search/EmbeddedListSearchHeader.tsx → Total Size: 2.6kB

  • ./src/app/entity/shared/components/styled/search/action/DeprecationDropdown.tsx → Total Size: 2.02kB

  • ./src/app/entity/shared/components/legacy/MarkdownViewer.tsx → Total Size: 2.81kB

  • ./src/app/entity/shared/components/styled/search/DownloadAsCsvModal.tsx → Total Size: 3.6kB

  • ./src/app/entity/shared/components/styled/search/action/DomainsDropdown.tsx → Total Size: 1.95kB

  • ./src/app/entity/shared/components/styled/StructuredProperty/MultiSelectInput.tsx → Total Size: 2.0kB

  • ./src/app/entity/shared/components/styled/search/action/GlossaryTermsDropdown.tsx → Total Size: 1.17kB

  • ./src/app/entity/shared/components/legacy/DescriptionModal.tsx → Total Size: 2.52kB

  • ./src/app/entity/shared/components/styled/StructuredProperty/MultipleOpenEndedInput.tsx → Total Size: 2.15kB

  • ./src/app/entity/shared/components/styled/search/action/OwnersDropdown.tsx → Total Size: 1.15kB

  • ./src/app/entity/shared/components/styled/StructuredProperty/NumberInput.tsx → Total Size: 888 bytes

  • ./src/app/entity/shared/components/styled/search/EmbeddedListSearch.tsx → Total Size: 7.48kB

  • ./src/app/entity/shared/components/styled/search/action/TagsDropdown.tsx → Total Size: 1.18kB

  • ./src/app/entity/shared/components/styled/search/MatchingViewsLabel.tsx → Total Size: 1.84kB

  • ./src/app/entity/shared/components/styled/search/SearchSelectBar.tsx → Total Size: 2.1kB

  • ./src/app/entity/shared/components/styled/search/EmbeddedListSearchResults.tsx → Total Size: 7.34kB

  • ./src/app/entity/shared/components/styled/search/EmbeddedListSearchModal.tsx → Total Size: 1.65kB

  • ./src/app/entity/shared/components/styled/search/SearchExtendedMenu.tsx → Total Size: 1.84kB

  • ./src/app/entity/shared/components/styled/ExpandedOwner/ExpandedOwner.tsx → Total Size: 3.05kB

  • ./src/i18n/i18n.ts → Total Size: 12.78kB

  • ./src/app/entity/shared/components/styled/search/action/ActionDropdown.tsx → Total Size: 1.35kB

  • ./src/app/entity/shared/components/styled/StructuredProperty/SingleSelectInput.tsx → Total Size: 1.6kB

Files in assets/en-*.js:

  • ./src/i18n/locales/en/entity.profile.stats.json → Total Size: 6.77kB

  • ./src/i18n/locales/en/entityV1.shared.components.json → Total Size: 4.57kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
datahub-web-react/src/i18n/i18n.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants