Skip to content

fix(i18n): use correct named components in Trans#17742

Open
v-tarasevich-blitz-brain wants to merge 1 commit into
masterfrom
vt--cat-2313--fix-trans-named-components
Open

fix(i18n): use correct named components in Trans#17742
v-tarasevich-blitz-brain wants to merge 1 commit into
masterfrom
vt--cat-2313--fix-trans-named-components

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR fixes wrong named tags in Trans component

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

✅ Meticulous spotted visual differences in 2 of 1302 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit 4675bf8 fix(i18n): use correct named components in Trans. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 145 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.51MB 145 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 33 bytes 8.85MB 0.0%
assets/en-*.js 72 bytes 208.85kB 0.03%
assets/de-*.js 40 bytes 47.72kB 0.08%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Documentation/components/RelatedDocumentItem.tsx → Total Size: 2.69kB

  • ./src/app/entityV2/shared/tabs/Entity/components/EntityList.tsx → Total Size: 3.48kB

  • ./src/app/settingsV2/AccessTokenModal.tsx → Total Size: 6.93kB

  • ./src/app/entityV2/shared/tabs/Documentation/components/LinkList.tsx → Total Size: 3.26kB

  • ./src/app/entityV2/shared/tabs/Documentation/components/RelatedLinkItem.tsx → Total Size: 3.06kB

  • ./src/app/identity/user/ViewResetTokenModal.tsx → Total Size: 3.86kB

Files in assets/en-*.js:

  • ./src/i18n/locales/en/entity.profile.tabs.json → Total Size: 886 bytes

  • ./src/i18n/locales/en/entity.profile.documentation.json → Total Size: 1.75kB

  • ./src/i18n/locales/en/entity.identity.json → Total Size: 9.94kB

  • ./src/i18n/locales/en/settings.tokens.json → Total Size: 4.84kB

Files in assets/de-*.js:

  • ./src/i18n/locales/de/entity.identity.json → Total Size: 9.68kB

  • ./src/i18n/locales/de/settings.tokens.json → Total Size: 5.2kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants