Skip to content

feat(i18n): extract keys from entity v1 entity dropdown#17743

Merged
v-tarasevich-blitz-brain merged 1 commit into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-entityV1-entity-dropdown
Jun 5, 2026
Merged

feat(i18n): extract keys from entity v1 entity dropdown#17743
v-tarasevich-blitz-brain merged 1 commit into
masterfrom
vt--cat-2222--translate-entity-shared-components-and-utilities-entityV1-entity-dropdown

Conversation

@v-tarasevich-blitz-brain
Copy link
Copy Markdown
Contributor

This PR extracts i18n keys from entity/shared/EntityDropdown

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jun 4, 2026

✅ Meticulous spotted 0 visual differences across 1302 screens tested: view results.

Meticulous evaluated ~10 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 5088ec6 feat(i18n): extract keys from entity v1 entity dropdown. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Bundle Report

Changes will increase total bundle size by 3.75kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 23.51MB 3.75kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 1.45kB 8.85MB 0.02%
assets/en-*.js 2.31kB 211.09kB 1.1%

Files in assets/index-*.js:

  • ./src/app/entity/shared/EntityDropdown/DomainParentSelect.tsx → Total Size: 2.82kB

  • ./src/app/entity/shared/EntityDropdown/MoveGlossaryEntityModal.tsx → Total Size: 3.81kB

  • ./src/i18n/i18n.ts → Total Size: 9.98kB

  • ./src/app/entity/shared/EntityDropdown/UpdateDeprecationModal.tsx → Total Size: 2.62kB

  • ./src/app/entity/shared/EntityDropdown/CreateGlossaryEntityModal.tsx → Total Size: 8.94kB

  • ./src/app/entity/shared/EntityDropdown/EntityDropdown.tsx → Total Size: 10.17kB

  • ./src/app/entity/shared/EntityDropdown/MoveDomainModal.tsx → Total Size: 3.07kB

  • ./src/app/entity/shared/EntityDropdown/useDeleteEntity.tsx → Total Size: 2.59kB

Files in assets/en-*.js:

  • ./src/i18n/locales/en/entityV1.shared.entityDropdown.json → Total Size: 2.39kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
datahub-web-react/src/i18n/i18n.ts 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 4, 2026
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain merged commit 6d49913 into master Jun 5, 2026
65 of 66 checks passed
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain deleted the vt--cat-2222--translate-entity-shared-components-and-utilities-entityV1-entity-dropdown branch June 5, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants