fix(sql-parsing): remove sqlglot.Expression compat shim#17758
Merged
Conversation
sqlglot.Expression was removed as a top-level re-export in v30. The shim restoring it was dead code — no runtime usage existed, only a comment in dataset.py which has been updated.
github-actions
Bot
added
the
ingestion
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Connector Tests ResultsAll connector tests passed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
sgomezvillamor
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlglot.Expression = sqlglot.expressions.Expressioncompat shim from_sqlglot_patch.pydataset.pythat referencedsqlglot.Expressionto use the correctsqlglot.expressions.ExpressionNo runtime code used
sqlglot.Expression— confirmed by grepping the full codebase.