Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic permissions to files #445

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Add basic permissions to files #445

merged 4 commits into from
Aug 26, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 25, 2023

Also refactor the permissions functions into a module to avoid circular imports with blocks.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ml-evs Matthew Evans
@ml-evs ml-evs force-pushed the ml-evs/files_tweaks branch from e0946c4 to b756bb3 Compare August 25, 2023 11:38
@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #437 ↗︎

0 44 0 0 Flakiness 0

Details:

Merge 126b5a0 into 8bc011e...
Project: datalab Commit: dfc3444f1e ℹ️
Status: Passed Duration: 05:11 💡
Started: Aug 25, 2023 2:52 PM Ended: Aug 25, 2023 2:58 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ml-evs ml-evs requested a review from jdbocarsly as a code owner August 25, 2023 13:54
ml-evs added 3 commits August 25, 2023 15:43

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ml-evs Matthew Evans
Revert type checker change

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ml-evs Matthew Evans

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ml-evs Matthew Evans
@ml-evs ml-evs force-pushed the ml-evs/files_tweaks branch from 224932a to 126b5a0 Compare August 25, 2023 14:43
@ml-evs ml-evs merged commit 7062af2 into main Aug 26, 2023
@ml-evs ml-evs deleted the ml-evs/files_tweaks branch August 26, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant