Use caches and staged builds in docker images and use buildkit in the CI #69
+338
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/docker_changes
branch
6 times, most recently
from
610ebbf to
66fa80a
Compare
ml-evs
changed the title
Closed
ml-evs
force-pushed
the
ml-evs/docker_changes
branch
from
57d72f9 to
66fa80a
Compare
- Add 'dev' and 'prod' profiles for use with docker-compose - Use package manager caches for pip and yarn within layers for faster local builds - Only install minimal deps for production builds
ml-evs
force-pushed
the
ml-evs/docker_changes
branch
from
33299bf to
07a1b73
Compare
ml-evs
force-pushed
the
ml-evs/docker_changes
branch
from
07a1b73 to
396f82a
Compare
|
Not sure how much you can usefully review this @jdbocarsly, so feel free to take a look but I will merge tonight unless I hear otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds staged builds to the docker images for the API and app, so that hot-reloading dev servers can also be used locally with Docker-based development environments.
It also:
I tried for hours to get layer caching to work between runs, but tools either support buildkit or docker-compose (not both) and even loading from the cache itself is a bit slow (see https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md). When we go open source, we could use GitHub's free container registry as a cache.