chore: make sure there are project.dependencies in pyproject #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool.hatch.metadata section containing allow-direct-references key (this option tells hatch that it is ok to build despite some dependencies being git+https) may be scheduled for removal before release, but the way it was introduced caused project.dependencies to become tool.hatch.metadata.dependencies which seems unintended. This commit moves dependencies back under project. This restores the ability to install by pointing pip at the project directory (or, in fact, through git+https). Previously, pip would find no project dependencies, and produce a non-functional installation of just the remake package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 82.38% 90.93% +8.54%
==========================================
Files 29 29
Lines 1158 1158
Branches 105 105
==========================================
+ Hits 954 1053 +99
+ Misses 162 75 -87
+ Partials 42 30 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started looking more closely into
pyproject.tomlto see what still needs to be done before release. Consider this WIP but also feel free to cherry-pick. I don't know myself how far should this PR take us. See commits for details.Some loose ends:
requirements.devel- either add asproject.optional-dependenciesor decide thathatch runis enough for all devel tasksexcludefor build? Currently, the sdist includes e.g..appveyor.ymland.github- which does not matter much, but is a couple of bytes nevertheless.tool.hatch.envsuseextra-dependenciesinstead ofdepoendencies, but onlytool.hatch.envs.testshas atemplatedefined, and there is nodefault; it seems to work and datalad-next does it in the same way, but is there a reason to only define extra-dependencies and not dependencies? I understood that extra- is mostly for inheritance.Ping #73
Reference: https://hatch.pypa.io/1.13/config/metadata/