Add separate lobbyist download page #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 10:15
|
@antidipyramid why isn't the heroku preview working? |
fgregg
suggested changes
Oct 23, 2024
| ), | ||
| path( | ||
| "lobbyist-downloads/", LobbyistDownloadView.as_view(), name="lobbyist-downloads" | ||
| ), |
There was a problem hiding this comment.
let's add a 301 redirect from downlods to camp-find-downloads.
antidipyramid
temporarily deployed
to
openness-pro-feature-37-atzawt
antidipyramid
temporarily deployed
to
openness-pro-feature-37-atzawt
fgregg
suggested changes
Oct 23, 2024
camp_fin/urls.py
Outdated
| @@ -104,6 +105,7 @@ | |||
| name="expenditure-detail", | |||
| ), | |||
| path("committees/", CommitteeList.as_view(), name="committee-list"), | |||
| path("downloads/", downloads_redirect_view, name="downloads"), | |||
There was a problem hiding this comment.
i think you can just do
path("downloads/",
HttpResponsePermanentRedirect(reverse("camp-fin-downloads")),
name="downloads"),seems clearer than creating a custom view that's just wrapping that up.
There was a problem hiding this comment.
Agreed. Doing it this way threw an error, so I used a RedirectView.
antidipyramid
temporarily deployed
to
openness-pro-feature-37-atzawt
fgregg
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a separate lobbyist download page. Since there are two download pages now (one for campaign finance and another for lobbyists) I renamed the templates and views accordingly.
Closes #221
Demo
Notes
Text content can be added to the page in the admin.
Testing Instructions