Fix parse to properly support multipleOf (to avoid validation error) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davicorreiajr
changed the title
AlexanderMann
requested changes
Mar 28, 2020
|
|
||
| assert singer_stream.peek_invalid_records() | ||
| assert singer_stream.count == 0 | ||
| assert [] == missing_sdc_properties(singer_stream) |
There was a problem hiding this comment.
I think we can drop this. It's not really adding value to the test overall.
| @@ -31,6 +32,8 @@ def test_python_type(): | |||
| == json_schema.STRING | |||
| assert json_schema.python_type('world') \ | |||
| == json_schema.STRING | |||
| assert json_schema.python_type(decimal.Decimal(1)) \ | |||
| == json_schema.NUMBER | |||
target_postgres/json_schema.py
Outdated
| @@ -1,6 +1,7 @@ | |||
| from copy import deepcopy | |||
| import json | |||
| import re | |||
| import decimal | |||
There was a problem hiding this comment.
This isn't documented anywhere, so I wouldn't expect you to know this one, but we try to alphabetize our imports. The breakdown is:
- Python
- 3rd Party
- Our code
…ert from test_BufferedSingerStream)
AlexanderMann
requested changes
Mar 30, 2020
|
|
||
| assert not singer_stream.peek_invalid_records() | ||
| assert singer_stream.count == len(multiple_of_values) | ||
| assert [] == missing_sdc_properties(singer_stream) |
There was a problem hiding this comment.
@davicorreiajr it's this line, we can remove it same as the other, sorry for the confusion and appreciate your patience!
There was a problem hiding this comment.
no worries, fixing now
AlexanderMann
approved these changes
Mar 30, 2020
|
Will merge and hopefully deploy later this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#178