Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions and versioningh #11

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Questions and versioningh #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13dd073
comments about suggested changes
antaldaniel Dec 13, 2024
1f1e6d4
Please, whenever you make checked changes,
antaldaniel Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: openmusesampling
Type: Package
Title: Data Collection for the Open Music Europe Project
Version: 0.1.0
Version: 0.1.0001
Authors@R:
c(person(given = "Daniel", family = "Antal",
email = "[email protected]",
Expand Down
12 changes: 10 additions & 2 deletions vignettes/wikipedia.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ These functions should work as long as you have the right name of the page on wi

Let's have a look at some Slovak artists from our list

```{r}
```{r articles}
## would it be possible to work with URLs or identity numbers of articles instead of their
## labels, as an alternative? for long-term it is easier to identify things via non-changin
## urls or ids.
article_title <- c("Živé kvety",
"Smejko a Tanculienka",
"Separ",
Expand Down Expand Up @@ -51,7 +54,12 @@ language_code <- "sk"
Let's just pass those names to our functions:


```{r}
```{r massretreive}
## I think it would be better to use a for loop here
## and purrr::safely to ensure that if there is an error on the side of the server
## your chain does not completely stop
## also the lapply loop with a longer list of articles will fill up the memory very fast

df <- lapply(1:length(article_title), function(i) data.frame(article_length = get_article_length(language_code, article_title[i]),
number_of_editors = get_unique_editors(language_code, article_title[i]),
creation_date = get_creation_date(language_code, article_title[i]),
Expand Down
Loading