Connect-DbaInstance, honor -Database parameter #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Invoke-ManualPester)Purpose
Honor
-Databaseparameter in some cases (passed connstring, passed registeredinstance).Approach
Connect-DbaInstance is quite a "hotpath" so I tried to make the edit just where needed, it shouldn't (finger crossed) break existing code, but we'll know from appveyor if so.
Commands to test
Before, this resulted in "master" being returned
Get-DbaRegServer -IncludeLocal | Connect-DbaInstance -Database msdb | % { $_.Query("select db_name()") }now, it returns "msdb".
On my laptop (tm) it also returns "msdb" for
Get-DbaRegServer -IncludeLocal | Connect-DbaInstance -Database msdb | Invoke-DbaQuery -Query 'select db_name();'as reported in #9541 (thanks @mattcargile and @ReeceGoding , both the original report and the findings made me waste little time in finding the culprit)