Move redis, environment to go-service-common #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
force-pushed
the
dev/paul/10403-privatise-sub-packages
branch
from
215297f to
c635522
Compare
eccles
requested review from
wp0pw,
honourfish,
j-hartley,
landintrees,
henry739 and
rcoxhill-01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results
robot:smoke: RESULTS: Tests 96 , Errors 0 , Failures 0 , Time 180.345
robot:core: RESULTS: Tests 532 , Errors 0 , Failures 2 , Time 627.178
robot:tenancies: RESULTS: Tests 38 , Errors 0 , Failures 0 , Time 722.051
robot:invites: RESULTS: Tests 23 , Errors 0 , Failures 0 , Time 8.051
robot:scitt: RESULTS: Tests 8 , Errors 0 , Failures 0 , Time 34.648
robot:abac: RESULTS: Tests 196 , Errors 0 , Failures 1 , Time 440.727
robot:obac: RESULTS: Tests 117 , Errors 0 , Failures 0 , Time 609.072
robot:slow-cd: RESULTS: Tests 4 , Errors 0 , Failures 0 , Time 39.33
The robot:core test failures are expected
Other failures were retested and passed
playright:api:smoke: 34 passed (25.3s)
playright:api:core: 41 passed (23.8s)
playright:api:app-registrations: 44 passed (34.0s)
playright:api:membership: 69 passed (57.8s)
playright:api:tenancies: 61 passed (32.9s)
playright:ui:authentication: 6 passed (54.7s)
playright:ui:management: 2 passed (15.1s)
playright:ui:product: 75 passed (16.4m)
AB#10403