Skip to content

Upgrade to go 1.24 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade to go 1.24 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.tools
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export TOOLS_BUILDNUMBER=20250403.6
2 changes: 2 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
**/go.sum -diff -merge
**/go.sum linguist-generated=true
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,15 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '1.23.x'
go-version: '1.24.x'
token: ${{ secrets.GITHUB_TOKEN }}
cache-dependency-path: |
datatrails-common-api/go.sum

- name: Install Go quality tools
run: |
go install golang.org/x/tools/cmd/[email protected]
go install github.com/axw/gocov/[email protected]
go install github.com/jstemmer/go-junit-report/[email protected]
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.3
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.2

- name: Code Quality
run: |
Expand Down
2 changes: 1 addition & 1 deletion eventsv1/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/datatrails/go-datatrails-serialization/eventsv1

go 1.23.0
go 1.24

require (
github.com/stretchr/testify v1.10.0
Expand Down
9 changes: 8 additions & 1 deletion eventsv1/test_results/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
mode: atomic
github.com/datatrails/go-datatrails-serialization/eventsv1/test.go:3.17,5.2 1 1
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:27.63,33.16 3 0
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:33.16,35.3 1 0
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:37.2,37.38 1 0
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:42.58,46.16 2 11
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:46.16,48.3 1 0
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:53.2,54.16 2 11
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:54.16,56.3 1 0
github.com/datatrails/go-datatrails-serialization/eventsv1/serializer.go:58.2,58.36 1 11
4 changes: 2 additions & 2 deletions taskfiles/Taskfile_gotest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ tasks:
-v \
-coverprofile={{.UNITTEST_DIR}}/main.out \
./... \
2>&1
2>&1

gocov convert {{.UNITTEST_DIR}}/main.out > {{.UNITTEST_DIR}}/coverage.json
go tool cover -html={{.UNITTEST_DIR}}/main.out -o {{.UNITTEST_DIR}}/coverage.html
Loading