Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1707 vite #1711

Merged
merged 7 commits into from
Jul 17, 2024
Merged

1707 vite #1711

merged 7 commits into from
Jul 17, 2024

Conversation

Flui
Copy link
Contributor

@Flui Flui commented Jul 16, 2024 •
edited
Loading

I updated the following things:

  • switch from CRA to vite
    • remove react-scripts
    • remove babel
  • switch from jest to vitest
  • update to node 20
  • update to eslint 9 including using the recommended rules
  • update to prettier 3

@Flui Flui force-pushed the 1707-vite branch 2 times, most recently from 6dd15f2 to bb83868 Compare July 16, 2024 05:50
@daviseford
Copy link
Owner

@Flui I fixed the eslint errors that remained. Now there's some issues with vitest. I can check back in/work on this tomorrow. GREAT WORK SO FAR!!!

@daviseford daviseford self-requested a review July 17, 2024 00:40
@daviseford daviseford added enhancement New feature or request maintenance not visible to the user, but important! dependencies Pull requests that update a dependency file labels Jul 17, 2024
@daviseford
Copy link
Owner

I think I fixed the tests :)

@daviseford
Copy link
Owner

Fixes #1707

@daviseford daviseford marked this pull request as ready for review July 17, 2024 13:22
@daviseford daviseford merged commit d585a0a into daviseford:master Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviseford daviseford Awaiting requested review from daviseford

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request maintenance not visible to the user, but important!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flui @daviseford