[CB] Ability to pin column in the Data Editor #3794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
commented
Oct 10, 2025
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridTable.tsx
Show resolved
Hide resolved
sergeyteleshev
commented
Oct 10, 2025
| focusSyncRef.current = { colIdx, rowIdx }; | ||
|
|
||
| this.selectCell({ colIdx, rowIdx }); | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Not in use anywhere. Only in the deleted piece below, so I removed it also
Wroud
requested changes
Oct 10, 2025
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridTable.tsx
Show resolved
Hide resolved
Wroud
requested changes
Dec 9, 2025
| const [dragOverElement, setDragOverElement] = useState<[number, boolean] | null>(null); | ||
|
|
||
| function getDataColIdxByKey(key: string) { | ||
| const columnIndex = columns.filter(isColumn).findIndex(col => col.key === key); |
Member
There was a problem hiding this comment.
Suggested change
| const columnIndex = columns.filter(isColumn).findIndex(col => col.key === key); | |
| const columnIndex = columns.findIndex(col => isColumn(col) && col.key === key); |
Member
There was a problem hiding this comment.
anyway this part probably will be changed if we will start using column groups
| model: IDatabaseDataModel; | ||
| actions: IDataTableActions; | ||
| spreadsheetActions: IDataPresentationActions<IGridDataKey>; | ||
| spreadsheetActions: IDataPresentationActions; |
| edit: (key: TKey) => void; | ||
| import type { IGridColumnKey, IGridDataKey } from '../DatabaseDataModel/Actions/Grid/IGridDataKey.js'; | ||
|
|
||
| export interface IDataPresentationActions { |
Comment on lines
-106
to
+107
| const columns = new Array<ColumnOrColumnGroup<IInnerRow, unknown>>(columnsCount) | ||
| .fill(null as any) | ||
| .map((_, i): ColumnOrColumnGroup<IInnerRow, unknown> => { | ||
| const width = getHeaderWidth?.(i) ?? 'max-content'; | ||
| return { | ||
| key: getColumnKey?.(i) ?? String(i), | ||
| name: '', | ||
| resizable: getHeaderResizable?.(i) ?? true, | ||
| width, | ||
| minWidth: 26, | ||
| editable: row => getCellEditable?.(row.idx, i) ?? false, | ||
| frozen: getHeaderPinned?.(i), | ||
| renderHeaderCell: mapRenderHeaderCell(i), | ||
| renderCell: mapCellContentRenderer(i), | ||
| renderEditCell: mapEditCellRenderer(i), | ||
| }; | ||
| }); | ||
| const columns = new Array<ColumnOrColumnGroup<IInnerRow, unknown>>(columnsCount).fill(null as any).map((_, i) => { |
Comment on lines
+119
to
+120
| renderEditCell: mapEditCellRenderer(i), | ||
| } as Column<IInnerRow, unknown>; |
Comment on lines
+287
to
+289
| pinColumn, | ||
| unpinColumn, | ||
| isColumnPinned, |
Member
There was a problem hiding this comment.
I will suggest using a different context for pinned columns, because right now every pin will trigger the rerender of all subscribers of the IDataGridContext
| import { createAction } from '@cloudbeaver/core-view'; | ||
|
|
||
| export const ACTION_DATA_GRID_PIN_COLUMN = createAction('data-grid-pin-column', { | ||
| label: 'data_grid_table_pin_column', |
Member
There was a problem hiding this comment.
please use proper localization key started with plugin's name as prefix: plugin_data_spreadsheet_new_
Comment on lines
+111
to
+117
| if (action === ACTION_DATA_GRID_PIN_COLUMN) { | ||
| return { ...action.info, label: 'data_grid_table_pin_column' }; | ||
| } | ||
|
|
||
| if (action === ACTION_DATA_GRID_UNPIN_COLUMN) { | ||
| return { ...action.info, label: 'data_grid_table_unpin_column' }; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/6859
Changes:
columnIdlogic. Now we have two types of IDs.Visual column idrepresents the column number on the screen. AnddataColIdx, which means the column index in the initial columns array provided to the data gridvisual column ID, some need to usedataColIdx. So used it respectively where required