[CB] Use only 1 Input component across the app #3938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PropertyItem (connection driver properties)
SychevAndrey
requested changes
Nov 28, 2025
webapp/packages/core-blocks/src/FormControls/InputField/InputField.tsx
Outdated
Show resolved
Hide resolved
webapp/packages/core-ui/src/InlineEditor/InlineEditor.module.css
Outdated
Show resolved
Hide resolved
Wroud
requested changes
Nov 28, 2025
webapp/common-react/@dbeaver/react-data-grid/src/editors/TextEditor.tsx
Outdated
Show resolved
Hide resolved
SychevAndrey
reviewed
Dec 2, 2025
| padding: 4px 7px; | ||
| font-size: 13px; | ||
| line-height: 24px; | ||
| padding: calc(2 * var(--tw-spacing)); |
Contributor
There was a problem hiding this comment.
is it ok that padding changed from 4 7 to 4 4?
Contributor
Author
There was a problem hiding this comment.
Its fine
Before:
After:
SychevAndrey
previously approved these changes
Dec 2, 2025
Wroud
previously approved these changes
Dec 3, 2025
Wroud
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/7041