dbeaver/pro#7636 add and fix tests #3940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HocKu7
previously approved these changes
Nov 27, 2025
alexander-skoblikov
previously approved these changes
Dec 2, 2025
Nexus6v2
reviewed
Dec 8, 2025
server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/utils/WebTestUtils.java
Show resolved
Hide resolved
...o.cloudbeaver.test.platform/src/io/cloudbeaver/model/navigator/WebNavigatorNodeInfoTest.java
Outdated
Show resolved
Hide resolved
| @Test | ||
| public void testGetObjectReturnsForDatabaseNode() { | ||
| WebSession session = Mockito.mock(WebSession.class); | ||
| Mockito.when(session.getLocale()).thenReturn("en"); |
Contributor
There was a problem hiding this comment.
These 2 line can be moved in @Before or @BeforeEach setup
| public DBPDataSourceRegistry getDataSourceRegistry() { | ||
| return registry; | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
I think you can move all the code above to setup method
Member
Author
There was a problem hiding this comment.
not really, different mocks
Contributor
There was a problem hiding this comment.
Yes, ds is different, but I think registry and project can be extracted
server/test/io.cloudbeaver.test.platform/src/io/cloudbeaver/model/session/WebSessionTest.java
Outdated
Show resolved
Hide resolved
Nexus6v2
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.