dbeaver/pro#4503 migrate admin tables to data grid #3942
+340
−391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...plugin-authentication-administration/src/Administration/Users/Teams/TeamsTable/TeamsPage.tsx
Show resolved
Hide resolved
...kages/plugin-authentication-administration/src/Administration/Users/UsersTable/UsersPage.tsx
Outdated
Show resolved
Hide resolved
...s/plugin-authentication-administration/src/Administration/Users/UsersTable/useUsersTable.tsx
Show resolved
Hide resolved
| <Group boxNoOverflow> | ||
| <TeamsTable teams={table.teams} state={table.state} selectedItems={table.tableState.selected} expandedItems={table.tableState.expanded} /> | ||
| </Group> | ||
| <TableSelectionContext value={selection}> |
Contributor
There was a problem hiding this comment.
Nice request! I also suggest syncing with the team on the topic of UI, which has changed from a stretched table to a compact one. I like that we now have more space for something else, but from an aesthetic point of view, I feel something a bit odd compared to the previous UI
Contributor
There was a problem hiding this comment.
Probably we should discuss it at UI/UX meeting and then with the next iteration fix issues if we find some
Wroud
requested changes
Dec 1, 2025
Comment on lines
44
to
51
|
|
||
| if (displayAuthRole) { | ||
| const isRole = COLUMNS.find(c => c.key === ROLE_COLUMN.key); | ||
|
|
||
| if (!isRole) { | ||
| COLUMNS.push(ROLE_COLUMN); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (displayAuthRole) { | |
| const isRole = COLUMNS.find(c => c.key === ROLE_COLUMN.key); | |
| if (!isRole) { | |
| COLUMNS.push(ROLE_COLUMN); | |
| } | |
| } | |
| let columns = COLUMNS; | |
| if (displayAuthRole) { | |
| columns = [...COLUMNS, ROLE_COLUMN]; | |
| } |
Member
Author
There was a problem hiding this comment.
Good point, better to create separate variable inside component and memo it
SychevAndrey
previously approved these changes
Dec 2, 2025
...ages/plugin-authentication-administration/src/Administration/Users/UsersTable/UsersTable.tsx
Show resolved
Hide resolved
sergeyteleshev
previously approved these changes
Dec 2, 2025
Wroud
previously approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 4503