fix: asset permissions #1110
Merged
fix: asset permissions #1110
+208
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <[email protected]>
* fix: kms key asset permissions Signed-off-by: lennartrommeiss <[email protected]> * fix: update tests Signed-off-by: lennartrommeiss <[email protected]> * fix: update some tests Signed-off-by: lennartrommeiss <[email protected]> --------- Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
=======================================
Coverage 71.80% 71.80%
=======================================
Files 3 3
Lines 461 461
=======================================
Hits 331 331
Misses 91 91
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <[email protected]>
|
This PR adds the function to grant KMS permissions automatically to key which is used by the default cdk bootstrap asset bucket. For this permissions for an KMS key lookup are necessary. This has no impact, if the S3 artifact is uploaded manually by setting ( To avoid the automatic key lookup set the new property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #