Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapse --sample and --sample-window into just --sample #11299

Open
Tracked by #11226
QMalcolm opened this issue Feb 12, 2025 · 0 comments · May be fixed by #11303
Open
Tracked by #11226

collapse --sample and --sample-window into just --sample #11299

QMalcolm opened this issue Feb 12, 2025 · 0 comments · May be fixed by #11303
Assignees
Labels
microbatch Issues related to the microbatch incremental strategy
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Feb 12, 2025

During the alpha implementation of sample mode we added CLI flags/options

  1. --sample for turning sample mode on/off
  2. --sample-window for specifying the window for sample mode

During the feedback session and additional discussion, we found it is likely better to have only one sample mode flag/option. With that in mind, we are going to combine the two into one. Thus, --sample will now take the sample window specification and --sample-window will go away.

@QMalcolm QMalcolm self-assigned this Feb 12, 2025
@QMalcolm QMalcolm added this to the v1.10 milestone Feb 12, 2025
@QMalcolm QMalcolm added the microbatch Issues related to the microbatch incremental strategy label Feb 12, 2025
@QMalcolm QMalcolm linked a pull request Feb 12, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
microbatch Issues related to the microbatch incremental strategy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant