Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine --sample and --sample-window into one CLI param #11303

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

QMalcolm
Copy link
Contributor

Resolves #11299

Problem

We had two CLI params from sample mode --sample and --sample-window. These were fairly duplicative. Although there was some benefit to having the separated, it created an undesirable experience

Solution

Collapse --sample-window into --sample.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm requested a review from a team as a code owner February 12, 2025 21:58
@cla-bot cla-bot bot added the cla:yes label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (2cde93b) to head (6807b79).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11303      +/-   ##
==========================================
- Coverage   88.95%   88.91%   -0.05%     
==========================================
  Files         189      189              
  Lines       24171    24169       -2     
==========================================
- Hits        21502    21489      -13     
- Misses       2669     2680      +11     
Flag Coverage Δ
integration 86.17% <100.00%> (-0.11%) ⬇️
unit 62.53% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.53% <40.00%> (-0.01%) ⬇️
Integration Tests 86.17% <100.00%> (-0.11%) ⬇️

@QMalcolm QMalcolm merged commit a08255e into main Feb 13, 2025
64 of 65 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--11299-single-sample-mode-flag branch February 13, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse --sample and --sample-window into just --sample
2 participants