fix: change target path for nodes defined in yml #11323
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11321
Problem
Models defined in yaml files (such as the new snapshots) are built to a file path such as
target/run/models/schema.yml/schema.yml/snapshot.sql
.This is both unclear and introduces possible collisions if
target/run/models/schema.yml
is a file.This path is made from joining the file path
models/schema.yml
with the 'logical' pathschema.yml/snapshot.sql
.Solution
If the basename of the file path matches the dirname of the logical path, construct a new path from:
models/
.
with_
:schema_yml/
snapshot.sql
Joined result being
models/schema_yml/snapshot.sql
Checklist