Merge pull request #406 from dbt-labs/fix/exposure-owner-name

Handle single quote in owner name and update test
dbt-labs · Jan 4, 2024 · 303e4ef · 303e4ef
2 parents 821c013 + b28a685
commit 303e4ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/integration_tests/models/marts/exposures.yml b/integration_tests/models/marts/exposures.yml
@@ -2,13 +2,13 @@ version: 2
 
 exposures:
   - name: exposure_1
-    description: real_dashboard
+    description: real_dashboard with fun chars '\!@#
     type: dashboard
     url: dave.com/metrics
     maturity: low
     tags: ['proserv']
     owner:
-      name: proserv
+      name: dave's davey
       email: [email protected]
 
     depends_on:

diff --git a/macros/unpack/get_exposure_values.sql b/macros/unpack/get_exposure_values.sql
@@ -22,8 +22,8 @@
               wrap_string_with_quotes(node.maturity),
               wrap_string_with_quotes(node.package_name),
               wrap_string_with_quotes(node.url),
-              wrap_string_with_quotes(node.owner.name),
-              wrap_string_with_quotes(node.owner.email),
+              wrap_string_with_quotes(dbt.escape_single_quotes(node.owner.name)),
+              wrap_string_with_quotes(dbt.escape_single_quotes(node.owner.email)),
               wrap_string_with_quotes(node.meta | tojson)
             ]
           %}